Github user c0s commented on the issue:

    https://github.com/apache/bigtop/pull/266
  
    I am looking at the diff and I see a few issue with it. 
    First, it adds two new file to the top level directory of the bigtop 
(TestMethods.java, HiveJdbcGeneralTest.java) - I don't think this is the 
intention, right?
    
    Second, there's an issue with the 'build.gradle file'. It seems there's a 
mix of commits off different bases. At any rate, you'd need to squash all the 
commits into one before we can allow it to the master.
    After looking at it for a bit, I'd recommend the following course of 
action. Make a fresh branch off bigtop's master. Copy the files your need and 
make any other changes you need to this newly created branch; make sure 
everything is up to your liking; commit, push and resubmit the PR. 
    
    Does it make sense? Thanks for your patience - git might be a bit too much 
some times ;)


---

Reply via email to