I know that flink have changed it's layout so the old build script doesn't match newer version of Flink. Can you elaborate more on your thinking of copying the whole build directory? Isn't that still copies files directory by directory?
I'm not that familiar with our build framework. But welcome to discuss here. Best, Evans functicons <[email protected]> 於 2018年6月28日 週四 上午6:34寫道： > HI folks, > > I have a question about install_flink.sh [1] in branch-1.2 works with Flink > 1.1.3 [2]. I don't quite understand why it copies files directory by > directory, e.g., it assumes resources/ exists in the build directory and > copies it to the target directory. > > The problem is that, in new versions of Flink, e.g. 1.3.1, 1) resources/ > doesn't exist and the script fails; 2) opt/ exists, but the script doesn't > copy it. So I have to update the script to reflect the new structure. > Wondering why don't simply copy the whole build directory to the target? > That way we don't need to make assumptions about the structure, it seems to > be more flexible and less error-prone. > > Let me know your thoughts. Thanks! > > Dagang > > [1]: > > https://github.com/apache/bigtop/blob/branch-1.2/bigtop-packages/src/common/flink/install_flink.sh#L123 > [2]: https://github.com/apache/bigtop/blob/branch-1.2/bigtop.bom#L318 >
