Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/401#discussion_r222415905
  
    --- Diff: bigtop_toolchain/bin/puppetize.sh ---
    @@ -40,7 +40,9 @@ case ${ID}-${VERSION_ID} in
             ;;
         centos-7*)
             rpm -ivh 
https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
    -        yum -y install hostname curl sudo unzip wget puppet 
puppetlabs-stdlib
    +        yum updateinfo
    +        yum -y install hostname curl sudo unzip wget puppet
    +        puppet module install puppetlabs-stdlib --version 4.12.0
    --- End diff --
    
    Mind to add a comment here to link to BIGTOP-3088? 
    This tells future developer that this line is for special case and can be 
removed if obstacle removed.


---

Reply via email to