youngwookim commented on issue #484: BIGTOP-3175. [Build] Support to specify commit SHA1 when building packages URL: https://github.com/apache/bigtop/pull/484#issuecomment-466852015 @evans-ye Good job! minor nits: - The sha-1 hash for commit is 'Commit Hash' I think 'commit hash' is easier to understand. - It would be nice if you add a content for the feature into README.md - https://github.com/apache/bigtop/blob/master/README.md#for-developers-building-a-component-from-git-repository
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
