evans-ye commented on a change in pull request #585: BIGTOP-3283. Bump HBase to
2.2.3.
URL: https://github.com/apache/bigtop/pull/585#discussion_r372763205
##########
File path: bigtop-packages/src/common/hbase/do-component-build
##########
@@ -36,13 +36,19 @@ if [ $HOSTTYPE = "aarch64" ] ; then
sed -i '/<version>1.5.0-alpha.6<\/version>/,+1d' ./pom.xml
sed -i
'/<artifactId>asciidoctorj-pdf<\/artifactId>/a\<version>1.5.0-alpha.6<\/version>\n</dependency>\n<dependency>\n<groupId>org.jruby<\/groupId>\n<artifactId>jruby-complete<\/artifactId>\n<version>9.1.8.0<\/version>\n<\/dependency>'
./pom.xml
fi
-mvn -DskipTests -Dslf4j.version=1.6.1 \
- -Dhadoop-two.version=$HADOOP_VERSION \
- -Dzookeeper.version=$ZOOKEEPER_VERSION \
- -Dcheckstyle.skip=true \
- ${MAVEN_ADDITIONAL} \
- install site assembly:single "$@"
+
+MAVEN_PARAMS=" -DskipTests "
+MAVEN_PARAMS+=" -Dslf4j.version=1.7.25 "
+MAVEN_PARAMS+=" -Dhadoop-two.version=${HADOOP_VERSION} "
+MAVEN_PARAMS+=" -Dzookeeper.version=${ZOOKEEPER_VERSION} "
+MAVEN_PARAMS+=" -Dcheckstyle.skip=true "
+
+# separate site and assembly:single to avoid assembly issues.
Review comment:
Got it. Thanks for the explanation. I suggest to add HBASE-21513 in the
comment so other users can find the root cause themselves. We used to have the
format like this:
```
# HBASE-21513: separate site and assembly:single to avoid assembly issues.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
