evans-ye commented on issue #597: BIGTOP-3165. Bump Spark to 2.4.4. URL: https://github.com/apache/bigtop/pull/597#issuecomment-587599883 Thanks for the detailed answer. And I'm glad that the change is captured instead of sliped through. So what I was worry about is that the LICENSE files can be outdated if we maintain our own copy. How about we add some safety to make sure that in any future upgrade, the licence file can be updated? Possible solutions: 1. Auto fetch licence file when building. The downside is this require network dependency, which may not be possible in company intranet. 2. Add a comment "remember to fetch new licence-binary" in common/spark alongside with the spark version defined in bigtop.bom. So when someone change it, the comment should be read. 3. Just get it in and hope that we can remember it in future upgrades ;) I slightly prefer 2..., any input from your end?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
