iwasakims commented on a change in pull request #615: BIGTOP-3300. Add puppet 
manifests for hadoop-kms.
URL: https://github.com/apache/bigtop/pull/615#discussion_r392640306
 
 

 ##########
 File path: bigtop-deploy/puppet/modules/kerberos/manifests/init.pp
 ##########
 @@ -189,8 +193,9 @@
     $keytab = "/etc/$title.keytab"
 
     $internal_princs = $spnego ? {
-      /(true|enabled)/ => [ 'HTTP' ],
-      default          => [ ],
+      true      => [ 'HTTP' ],
+      'enabled' => [ 'HTTP' ],
+      default   => [ ],
 
 Review comment:
   Yes. The credential of HTTP/host@REALM did not written to keytab file since 
boolean `true` was not covered in the conditional of previous code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to