evans-ye commented on issue #555: BIGTOP-3264: Add a new Bigtop Mpack definition for Ambari URL: https://github.com/apache/bigtop/pull/555#issuecomment-600086228 Yes. I know what you're doing and that's good to me. My concern is this PR contains binaries: ``` ... 1811 diff -ruaN apache-ambari-2.6.1-src.orig/contrib/management-packs/bgtp-ambari-mpack/src/main/resources/stacks/BGTP/1.0/hooks/before-START/files/fast-hdfs-resource .jar apache-ambari-2.6.1-src/contrib/management-packs/bgtp-ambari-mpack/src/main/resources/stacks/BGTP/1.0/hooks/before-START/files/fast-hdfs-resource.jar 1812 --- apache-ambari-2.6.1-src.orig/contrib/management-packs/bgtp-ambari-mpack/src/main/resources/stacks/BGTP/1.0/hooks/before-START/files/fast-hdfs-resource.jar 1 970-01-01 00:00:00.000000000 +0000 1813 +++ apache-ambari-2.6.1-src/contrib/management-packs/bgtp-ambari-mpack/src/main/resources/stacks/BGTP/1.0/hooks/before-START/files/fast-hdfs-resource.jar 2 020-01-20 06:13:59.600283718 +0000 1814 @@ -0,0 +1,68767 @@ 1815 +PK^C^D^T^@^H^H^H^@º<8e>wH^@^@^@^@^@^@^@^@^@^@^@^@^T^@^D^@META-INF/MANIFEST.MFþÊ^@^@E<8e>A ... ``` Could you double check on that?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
