evans-ye commented on a change in pull request #620: BIGTOP-3319: Add Logstash as Bigtop component URL: https://github.com/apache/bigtop/pull/620#discussion_r406363668
########## File path: bigtop-packages/src/common/logstash/patch0-logstash.diff ########## @@ -0,0 +1,2393 @@ +diff -ruaN logstash-5.4.1/bin/bundle linaro-logstash-5.4.1/bin/bundle Review comment: Usually for apache project we just name it like patch0-HBASE-16864.diff, which we can easily find the source. For this one... how about we name it something like patch0-logstash-for-arm64.diff so that it's more clear. Also add the source of the patch in Bigtop-3319, which helps people to locate where the change come from. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
