evans-ye commented on pull request #620: URL: https://github.com/apache/bigtop/pull/620#issuecomment-632804825
>> If put ruby-2.4.0 in Bigtop_toolchain, ruby-2.4.0 is used for both build-time and runtime. This is not correct. If put ruby-2.4.0 in bigtop_toolchain, It's used in build time only. Why you say so? >> Install ruby-2.4.0 in do-component-build: >> It's just for logstash build-time. Even though we do this. We should remove the ruby installation after logstash is built. Otherwise the build env is tainted. Can we guarantee a clean removal? I don't think dynamic dependency installation is a good way to go. We should make build env consistent. The way we do it is bigtop toolchain. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
