guyuqi commented on pull request #620: URL: https://github.com/apache/bigtop/pull/620#issuecomment-633419110
>>_This is not correct. If put ruby-2.4.0 in bigtop_toolchain, It's used in build time only. Why you say so?_ Maybe I have misunderstanding here and please correct me: In docker build scripts of bigtop-slaves: https://github.com/apache/bigtop/blob/master/docker/bigtop-slaves/build.sh#L45-L79 The ruby-2.4.0 as the part of `bigtop_toolchain` would be contained in the docker images like` bigtop/slaves :xxx-ubuntu-18.04. ` If we run the logstash against in this docker image, ruby-2.4.0 would override the ruby-2.5 provided by Ubuntu-18.04. >>_I don't think dynamic dependency installation is a good way to go. We should make build env consistent. The way we do it is bigtop toolchain._ For the reason above and the disscussion in #632, ruby would not be installed in bigtop_toolchain. I agree with you that dynamic dependency installation in `do-component-build` is not an elegant solution, but it may be a feasible approach just for this case. Surely I would like to remove the ruby installation after logstash is built by [rvm remove](https://rvm.io/rubies/removing). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
