iwasakims commented on a change in pull request #697:
URL: https://github.com/apache/bigtop/pull/697#discussion_r521787309



##########
File path: bigtop-packages/src/common/spark/do-component-build
##########
@@ -23,7 +23,7 @@ BUILD_OPTS="-Divy.home=${HOME}/.ivy2 
-Dsbt.ivy.home=${HOME}/.ivy2 -Duser.home=${
             -Dreactor.repo=file://${HOME}/.m2/repository \
             -Dhadoop.version=$HADOOP_VERSION \
             -Dyarn.version=$HADOOP_VERSION \
-            -Pyarn -Phadoop-2.7 \
+            -Pyarn -Phadoop-$HADOOP_VERSION \

Review comment:
       The pom does not have profile such as hadoop-2.10.1.
   https://github.com/apache/spark/blob/v2.4.5/pom.xml#L2740-L2775
   
   We need to patch the pom.xml if additional profile is required. Just 
overriding the properties in the hadoop-2.7 profile does not work? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to