elukey commented on pull request #754: URL: https://github.com/apache/bigtop/pull/754#issuecomment-798684616
I am going to discard this there were a lot of efforts to migrate to puppet 5.x but we decided to avoid it: https://issues.apache.org/jira/browse/BIGTOP-3161 https://lists.apache.org/thread.html/26e14cf36e9cfd61e0de581ed83bf305565c2e65234f1ce3bfb97628@%3Cdev.bigtop.apache.org%3E I hoped to be able to move to lookup but the function varies too much from puppet 3 to 5, and adding a ton of conditionals in the code to support both seems only polluting the code with no benefit.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
