iwasakims commented on a change in pull request #759:
URL: https://github.com/apache/bigtop/pull/759#discussion_r595017794
##########
File path: bigtop-packages/src/common/hadoop/do-component-build
##########
@@ -125,6 +125,8 @@ MAVEN_OPTS+="-DskipTests -DskipTest -DskipITs "
. $(dirname ${0})/maven_deploy.sh
# Build artifacts
+# remove phantomjs dependency
+sed -i '/^phantomjs-prebuilt/,+12d;N;/phantomjs/!P;D'
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/yarn.lock
Review comment:
Should we use `patch*.diff` file rather than ad hoc editing in the
do-component-build? I think the sed scripting is possible to modify the file in
unexpected way if the yarn.lock is updated (on Hadoop side).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
