JunHe77 commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648123377



##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
 # Include common Maven Deployment logic
 . $(dirname ${0})/maven_deploy.sh
 
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+    centos-7)
+        mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc 
-Dversion=2.6.1-build3 \
+            -Dclassifier=linux-aarch_64 -Dpackaging=exe 
-Dfile=/usr/local/bin/protoc

Review comment:
       "linux-aarch_64" is hardcoded. This should be changed to reflect certain 
non-x86 platform.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to