iwasakims commented on pull request #838:
URL: https://github.com/apache/bigtop/pull/838#issuecomment-986838129


   Ordering between classes could be used instead of the `Package<||> -> 
Exec<||>` like
   
   ```
   $ git diff
   diff --git a/bigtop_toolchain/manifests/installer.pp 
b/bigtop_toolchain/manifests/installer.pp
   index bcf9ee7..4ce5f67 100644
   --- a/bigtop_toolchain/manifests/installer.pp
   +++ b/bigtop_toolchain/manifests/installer.pp
   @@ -25,6 +25,10 @@ class bigtop_toolchain::installer {
      include bigtop_toolchain::renv
      include bigtop_toolchain::grpc
   
   +  Class['bigtop_toolchain::packages'] -> Class['bigtop_toolchain::maven']
   +  Class['bigtop_toolchain::packages'] -> Class['bigtop_toolchain::ant']
   +  Class['bigtop_toolchain::packages'] -> Class['bigtop_toolchain::gradle']
   +
      stage { 'last':
        require => Stage['main'],
      }
   diff --git a/bigtop_toolchain/manifests/packages.pp 
b/bigtop_toolchain/manifests/packages.pp
   index 93e6c0a..b8e3be8 100644
   --- a/bigtop_toolchain/manifests/packages.pp
   +++ b/bigtop_toolchain/manifests/packages.pp
   @@ -250,8 +250,13 @@ class bigtop_toolchain::packages {
            ensure => latest
          }
        }
   -  }
   
   +    if $operatingsystemmajrelease == 7 {
   +      package { ca-certificates:
   +        ensure => latest
   +      }
   +    }
   +  }
   
      # BIGTOP-3364: Failed to install setuptools by pip/pip2
      # on Ubuntu-16.04/18.04 and centos-7.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to