iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r775136310
##########
File path: bigtop-tests/smoke-tests/kafka/TestKafkaSmoke.groovy
##########
@@ -32,20 +32,7 @@ class TestKafkaSmoke {
static Shell sh = new Shell("/bin/bash -s");
static final String KAFKA_HOME = "/usr/lib/kafka"
- static final String KAFKA_CONFIG = KAFKA_HOME + "/config/server.properties "
static final String KAFKA_TOPICS = KAFKA_HOME + "/bin/kafka-topics.sh "
- static final String KAFKA_SERVER_START = KAFKA_HOME +
"/bin/kafka-server-start.sh "
- static final String KAFKA_SERVER_STOP = KAFKA_HOME +
"/bin/kafka-server-stop.sh "
-
- @BeforeClass
- static void kafkaSetUp() {
Review comment:
The original code is trying to change the configuration value of
`delete.topic.enable` by restating Kafka broker. Just running
`/bin/kafka-server-stop.sh` does not work if the Kafka broker was started as a
service via systemctl. `--smoke-tests` of docker provisioner is the case.
Setting configurations required for smoke-tests in the config files should be
simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
