HalimKim opened a new pull request, #949:
URL: https://github.com/apache/bigtop/pull/949

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   Zeppelin home directory should include plugins directory. Current Bigtop 
zeppelin spec file and install_zeppelin.sh file does not specify plugins 
directory 
   
   Build will be successful and rpm file will be generated without any error 
even if there is no specification about plugins directory.
   
   However when you install rpm and run zeppelin notebook, you will see Logs 
Like below
   
   ```java
   ...
    WARN [2022-07-18 10:29:36,366] ({ImmediateThread-1658107775074} 
PluginManager.java[getPluginClassLoader]:192) - PluginFolder 
/usr/nch/current/zeppelin-server/plugins/NotebookRepo/FileSystemNotebookRepo 
doesn't exist or is not a directory
   ...
   ERROR [2022-07-18 10:29:38,364] ({main} ZeppelinServer.java[main]:262) - 
Error while running jettyServer
   java.lang.Exception: A MultiException has 2 exceptions.  They are:
   1. java.lang.NullPointerException
   2. java.lang.IllegalStateException: Unable to perform operation: create on 
org.apache.zeppelin.notebook.repo.NotebookRepoSync
   
           at 
org.apache.zeppelin.server.ZeppelinServer.main(ZeppelinServer.java:256)
   Caused by: A MultiException has 2 exceptions.  They are:
   1. java.lang.NullPointerException
   2. java.lang.IllegalStateException: Unable to perform operation: create on 
org.apache.zeppelin.notebook.repo.NotebookRepoSync
   
           at org.jvnet.hk2.internal.ClazzCreator.create(ClazzCreator.java:368)
           at 
org.jvnet.hk2.internal.SystemDescriptor.create(SystemDescriptor.java:463)
           at 
org.glassfish.hk2.utilities.ImmediateContext.findOrCreate(ImmediateContext.java:111)
           at 
org.jvnet.hk2.internal.Utilities.createService(Utilities.java:2102)
           at 
org.jvnet.hk2.internal.ServiceHandleImpl.getService(ServiceHandleImpl.java:93)
           at 
org.jvnet.hk2.internal.ServiceHandleImpl.getService(ServiceHandleImpl.java:67)
           at 
org.glassfish.hk2.utilities.ImmediateContext.doWork(ImmediateContext.java:290)
           at 
org.glassfish.hk2.internal.ImmediateHelper.run(ImmediateHelper.java:233)
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
           at java.lang.Thread.run(Thread.java:748)
   Caused by: java.lang.NullPointerException
           at 
org.apache.zeppelin.notebook.repo.NotebookRepoSync.init(NotebookRepoSync.java:84)
           at 
org.apache.zeppelin.notebook.repo.NotebookRepoSync.<init>(NotebookRepoSync.java:63)
           at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
Method)
           at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
           at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
           at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
           at 
org.glassfish.hk2.utilities.reflection.ReflectionHelper.makeMe(ReflectionHelper.java:1356)
           at 
org.jvnet.hk2.internal.ClazzCreator.createMe(ClazzCreator.java:248)
           at org.jvnet.hk2.internal.ClazzCreator.create(ClazzCreator.java:342)
           ... 10 more
   ...
   ```
   
   So I put specification of plugins dir to spec file and install_zeppelin.sh
   
   ### How was this patch tested?
   1. modify spec file and install_zeppelin.sh (install plugins dir and 
specifying location of plugins dir) 
   2. run gradle task
   ```bash
   ./gradlew zeppelin-clean zeppelin-pkg
   ```
   3. Check "BUILD SUCCESSFULL" message
   4. Check RPM file list 
   ```bash
   rpm -qlp <ZEPPELIN_RPM> | grep plugins
   ```
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'BIGTOP-3638. Your PR title ...')?
   - [x] Make sure that newly added files do not have any licensing issues. 
When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to