iwasakims commented on code in PR #1017: URL: https://github.com/apache/bigtop/pull/1017#discussion_r974859207
########## bigtop-packages/src/deb/phoenix/control: ########## @@ -23,7 +23,7 @@ Homepage: http://phoenix.apache.org Package: phoenix Architecture: all -Depends: zookeeper, hadoop, hadoop-mapreduce, hadoop-yarn, hbase, bigtop-utils (>= 0.7) Review Comment: I guess the original author added the dependency for tools like [Phoenix Map Reduce](https://phoenix.apache.org/phoenix_mr.html) using libraries of Hadoop. While tools installed under /usr/lib/phoenix/bin uses classpath assuming hadoop, it does not assume hbase classpath because fat cliant jar contains HBase classes. ``` -cp "/etc/hbase/conf:/usr/lib/phoenix/bin/../phoenix-client-hbase-2.4-5.1.2.jar:/etc/hadoop/conf:/etc/hadoop/conf:/usr/lib/hadoop/lib/*:/usr/lib/hadoop/.//*:/usr/lib/hadoop-hdfs/./:/usr/lib/hadoop-hdfs/lib/*:/usr/lib/hadoop-hdfs/.//*:/usr/lib/hadoop-mapreduce/.//*:/usr/lib/hadoop-yarn/./:/usr/lib/hadoop-yarn/lib/*:/usr/lib/hadoop-yarn/.//*" ``` ``` # jar tvf /usr/lib/phoenix/phoenix-client-hbase-2.4-5.1.2.jar | grep org.apache.hadoop.hbase.client | head -n 3 0 Wed Jan 22 15:10:16 UTC 2020 org/apache/hadoop/hbase/client/ 570 Wed Jan 22 15:10:16 UTC 2020 org/apache/hadoop/hbase/client/RegionInfoUtil.class 1312 Wed Jan 22 15:10:16 UTC 2020 org/apache/hadoop/hbase/client/AbstractClientScanner.class # jar tvf /usr/lib/phoenix/phoenix-client-hbase-2.4-5.1.2.jar | grep org.apache.hadoop.hbase | wc -l 8380 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
