sekikn commented on PR #1019: URL: https://github.com/apache/bigtop/pull/1019#issuecomment-1263648232
LGTM, tested as follows: ``` $ ./gradlew hadoop-clean hadoop-pkg repo -Dbuildwithdeps=true $ mv output/hadoop /tmp $ curl -sL https://github.com/apache/bigtop/pull/1019.diff | git apply <stdin>:279: trailing whitespace. install -d -m 0755 $PREFIX/$HDFS_DIR/lib <stdin>:456: trailing whitespace. rm -rf `find $PREFIX/$ETC_HADOOP/$conf -name .svn -type d` warning: 2 lines add whitespace errors. $ ./gradlew hadoop-clean hadoop-pkg repo -Dbuildwithdeps=true $ for i in $(ls output/hadoop/x86_64); do diff <(rpm -qlp output/hadoop/x86_64/$i) <(rpm -qlp /tmp/hadoop/x86_64/$i); done 3d2 < /etc/hadoop $ ./gradlew hadoop-clean hadoop-pkg repo -Dbuildwithdeps=true -PparentDir=/usr/bigtop $ for i in $(ls output/hadoop/x86_64); do echo $i; rpm -qlp output/hadoop/x86_64/$i; echo; done hadoop-3.3.4-1.el8.x86_64.rpm /etc/bash_completion.d/hadoop /etc/hadoop /usr/bigtop/etc/default/hadoop /usr/bigtop/etc/hadoop/conf.empty/configuration.xsl /usr/bigtop/etc/hadoop/conf.empty/core-site.xml /usr/bigtop/etc/hadoop/conf.empty/hadoop-env.sh /usr/bigtop/etc/hadoop/conf.empty/hadoop-metrics2.properties /usr/bigtop/etc/hadoop/conf.empty/hadoop-policy.xml /usr/bigtop/etc/hadoop/conf.empty/log4j.properties /usr/bigtop/etc/hadoop/conf.empty/ssl-client.xml.example /usr/bigtop/etc/hadoop/conf.empty/ssl-server.xml.example /usr/bigtop/etc/hadoop/conf.empty/workers /usr/bigtop/usr/bin/hadoop /usr/bigtop/usr/lib/hadoop/bin ... /usr/bigtop/usr/lib/hadoop/tools/lib/zstd-jni-1.4.9-1.jar /usr/bigtop/usr/share/man/man1/hadoop.1.gz /usr/bigtop/usr/share/man/man1/hdfs.1.gz /usr/bigtop/usr/share/man/man1/mapred.1.gz /usr/bigtop/usr/share/man/man1/yarn.1.gz hadoop-client-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/lib/hadoop/client ... /usr/bigtop/usr/lib/hadoop/client/woodstox-core.jar hadoop-conf-pseudo-3.3.4-1.el8.x86_64.rpm /usr/bigtop/etc/hadoop/conf.pseudo ... /usr/bigtop/etc/hadoop/conf.pseudo/yarnservice-log4j.properties hadoop-debuginfo-3.3.4-1.el8.x86_64.rpm /usr/lib/debug ... /usr/lib/debug/usr/bigtop/usr/lib/hadoop/lib/native/libnativetask.so.1.0.0-3.3.4-1.el8.x86_64.debug hadoop-debugsource-3.3.4-1.el8.x86_64.rpm /usr/src/debug/hadoop-3.3.4-1.el8.x86_64 ... /usr/src/debug/hadoop-3.3.4-1.el8.x86_64/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native hadoop-doc-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/share/doc/hadoop-3.3.4 ... /usr/bigtop/usr/share/doc/hadoop-3.3.4/project-reports.html hadoop-hdfs-3.3.4-1.el8.x86_64.rpm /etc/security/limits.d/hdfs.conf /usr/bigtop/etc/hadoop/conf.empty/hdfs-site.xml /usr/bigtop/usr/bin/hdfs /usr/bigtop/usr/lib/hadoop-hdfs ... /usr/bigtop/usr/lib/hadoop/libexec/init-hdfs.sh /usr/bigtop/var/lib/hadoop-hdfs /usr/bigtop/var/lib/hadoop-hdfs/cache /var/log/hadoop-hdfs /var/run/hadoop-hdfs hadoop-hdfs-datanode-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-datanode /usr/bigtop/etc/default/hadoop-hdfs-datanode hadoop-hdfs-dfsrouter-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-dfsrouter /usr/bigtop/etc/default/hadoop-hdfs-dfsrouter hadoop-hdfs-fuse-3.3.4-1.el8.x86_64.rpm /usr/bigtop/etc/default/hadoop-fuse /usr/bigtop/usr/bin/hadoop-fuse-dfs /usr/bigtop/usr/lib/hadoop/bin/fuse_dfs hadoop-hdfs-fuse-debuginfo-3.3.4-1.el8.x86_64.rpm /usr/lib/debug ... /usr/lib/debug/usr/bigtop/usr/lib/hadoop/bin/fuse_dfs-3.3.4-1.el8.x86_64.debug hadoop-hdfs-journalnode-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-journalnode /usr/bigtop/etc/default/hadoop-hdfs-journalnode hadoop-hdfs-namenode-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-namenode /usr/bigtop/etc/default/hadoop-hdfs-namenode hadoop-hdfs-secondarynamenode-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-secondarynamenode /usr/bigtop/etc/default/hadoop-hdfs-secondarynamenode hadoop-hdfs-zkfc-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-hdfs-zkfc /usr/bigtop/etc/default/hadoop-hdfs-zkfc hadoop-httpfs-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-httpfs /usr/bigtop/etc/default/hadoop-httpfs /usr/bigtop/etc/hadoop/conf.empty/httpfs-env.sh /usr/bigtop/etc/hadoop/conf.empty/httpfs-log4j.properties /usr/bigtop/etc/hadoop/conf.empty/httpfs-site.xml /usr/bigtop/var/lib/hadoop-httpfs /var/log/hadoop-httpfs /var/run/hadoop-httpfs hadoop-kms-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-kms /usr/bigtop/etc/default/hadoop-kms /usr/bigtop/etc/hadoop/conf.empty/kms-acls.xml /usr/bigtop/etc/hadoop/conf.empty/kms-env.sh /usr/bigtop/etc/hadoop/conf.empty/kms-log4j.properties /usr/bigtop/etc/hadoop/conf.empty/kms-site.xml /usr/bigtop/var/lib/hadoop-kms /var/log/hadoop-kms /var/run/hadoop-kms hadoop-libhdfs-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/lib64/libhdfs.so /usr/bigtop/usr/lib64/libhdfs.so.0.0.0 hadoop-libhdfs-debuginfo-3.3.4-1.el8.x86_64.rpm /usr/lib/debug ... /usr/lib/debug/usr/bigtop/usr/lib64/libhdfs.so.0.0.0-3.3.4-1.el8.x86_64.debug hadoop-libhdfs-devel-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/include/hdfs.h hadoop-libhdfspp-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/lib64/libhdfspp.so /usr/bigtop/usr/lib64/libhdfspp.so.0.1.0 hadoop-libhdfspp-debuginfo-3.3.4-1.el8.x86_64.rpm /usr/lib/debug ... /usr/lib/debug/usr/bigtop/usr/lib64/libhdfspp.so.0.1.0-3.3.4-1.el8.x86_64.debug hadoop-libhdfspp-devel-3.3.4-1.el8.x86_64.rpm /usr/bigtop/usr/include/hdfspp ... /usr/bigtop/usr/include/hdfspp/uri.h hadoop-mapreduce-3.3.4-1.el8.x86_64.rpm /etc/security/limits.d/mapreduce.conf /usr/bigtop/etc/hadoop/conf.empty/mapred-env.sh /usr/bigtop/etc/hadoop/conf.empty/mapred-queues.xml.template /usr/bigtop/etc/hadoop/conf.empty/mapred-site.xml /usr/bigtop/usr/bin/mapred /usr/bigtop/usr/lib/hadoop-mapreduce ... /usr/bigtop/usr/lib/hadoop-mapreduce/sbin /usr/bigtop/usr/lib/hadoop-mapreduce/sbin/mr-jobhistory-daemon.sh /usr/bigtop/usr/lib/hadoop/libexec/mapred-config.sh /usr/bigtop/var/lib/hadoop-mapreduce /usr/bigtop/var/lib/hadoop-mapreduce/cache /var/log/hadoop-mapreduce /var/run/hadoop-mapreduce hadoop-mapreduce-historyserver-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-mapreduce-historyserver /usr/bigtop/etc/default/hadoop-mapreduce-historyserver hadoop-yarn-3.3.4-1.el8.x86_64.rpm /etc/security/limits.d/yarn.conf /usr/bigtop/etc/hadoop/conf.empty/capacity-scheduler.xml /usr/bigtop/etc/hadoop/conf.empty/container-executor.cfg /usr/bigtop/etc/hadoop/conf.empty/yarn-env.sh /usr/bigtop/etc/hadoop/conf.empty/yarn-site.xml /usr/bigtop/usr/bin/yarn /usr/bigtop/usr/lib/hadoop-yarn ... /usr/bigtop/usr/lib/hadoop/libexec/yarn-config.sh /usr/bigtop/var/lib/hadoop-yarn /usr/bigtop/var/lib/hadoop-yarn/cache /var/log/hadoop-yarn /var/run/hadoop-yarn hadoop-yarn-debuginfo-3.3.4-1.el8.x86_64.rpm /usr/lib/debug ... /usr/lib/debug/usr/bigtop/usr/lib/hadoop-yarn/bin/container-executor-3.3.4-1.el8.x86_64.debug hadoop-yarn-nodemanager-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-yarn-nodemanager /usr/bigtop/etc/default/hadoop-yarn-nodemanager hadoop-yarn-proxyserver-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-yarn-proxyserver /usr/bigtop/etc/default/hadoop-yarn-proxyserver hadoop-yarn-resourcemanager-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-yarn-resourcemanager /usr/bigtop/etc/default/hadoop-yarn-resourcemanager hadoop-yarn-router-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-yarn-router /usr/bigtop/etc/default/hadoop-yarn-router hadoop-yarn-timelineserver-3.3.4-1.el8.x86_64.rpm /etc/rc.d/init.d/hadoop-yarn-timelineserver /usr/bigtop/etc/default/hadoop-yarn-timelineserver ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
