yoda-mon commented on code in PR #1043:
URL: https://github.com/apache/bigtop/pull/1043#discussion_r1000112149
##########
bigtop_toolchain/manifests/installer.pp:
##########
@@ -14,6 +14,7 @@
# limitations under the License.
class bigtop_toolchain::installer {
+ include bigtop_toolchain::jdk11
include bigtop_toolchain::jdk
Review Comment:
At this this time Java 11 is just an option and `bigtop-deploy` also has the
puppet file named `jdk.pp`, so I avoid the risk for changing the name.
To keep the code clean `jdk8` might be fine, so if we will find the way to
add an option for Java 11 on deployment, that would be the time to chage the
file name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
