iwasakims commented on code in PR #1054:
URL: https://github.com/apache/bigtop/pull/1054#discussion_r1034603132
##########
bigtop-packages/src/common/ambari/patch12-fix-ambari-metrics-grafana-service-issues.diff:
##########
@@ -0,0 +1,44 @@
+diff --git
a/ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
b/ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
+index dba2f5ff55..edd3ec1a09 100644
+--- a/ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
++++ b/ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
+@@ -118,7 +118,7 @@ case "$1" in
+ then
+ for i in {1..10}
+ do
+- sleep 2
++ sleep 12
+ # check if pid file has been written to
+ if [ -s $PID_FILE ]; then
+ echo " $(date) pid_file has been written to" >> $LOG_FILE
+@@ -131,18 +131,19 @@ case "$1" in
+ echo " $(date) Start FAILED because daemon did not write pid in
pid_file after 20 seconds" >> $LOG_FILE
+ exit 1
+ fi
+- i=0
+- timeout=60
++ #i=0
++ #timeout=60
+ # Wait for the process to be properly started before exiting
+- until { cat "$PID_FILE" | xargs kill -0; } >/dev/null 2>&1
+- do
+- sleep 1
+- i=$(($i + 1))
+- if [ $i -gt $timeout ]; then
+- echo "FAILED"
+- exit 1
+- fi
+- done
++ sleep 120
++ #until { cat "$PID_FILE" | xargs kill -0; } >/dev/null 2>&1
++ #do
++ # sleep 1
++ # i=$(($i + 1))
++ # if [ $i -gt $timeout ]; then
++ # echo "FAILED"
++ # exit 1
++ # fi
++ #done
Review Comment:
You should add comment explaining why this should be commented out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
