guyuqi commented on code in PR #1095:
URL: https://github.com/apache/bigtop/pull/1095#discussion_r1152661319
##########
bigtop-packages/src/common/hadoop/do-component-build:
##########
@@ -120,6 +120,12 @@ if [ -z "$BUNDLE_SNAPPY" ] ; then
[ -f /usr/lib/${HOSTTYPE}-linux-gnu/libsnappy.so ] &&
BUNDLE_SNAPPY="-Dsnappy.prefix=x -Dbundle.snappy=true
-Dsnappy.lib=/usr/lib/${HOSTTYPE}-linux-gnu"
fi
+if [ -z "$BUNDLE_ZSTD" ] ; then
+ [ -f /usr/lib/libzstd.so ] && BUNDLE_ZSTD="-Dbundle.zstd=true
-Dzstd.lib=/usr/lib"
+ [ -f /usr/lib64/libzstd.so ] && BUNDLE_ZSTD="-Dbundle.zstd=true
-Dzstd.lib=/usr/lib64"
+ [ -f /usr/lib/${HOSTTYPE}-linux-gnu/libzstd.so ] &&
BUNDLE_ZSTD="-Dbundle.zstd=true -Dzstd.lib=/usr/lib/${HOSTTYPE}-linux-gnu"
Review Comment:
> emmm, I only have CentOS 7.4 at hand. Can someone help to verify other
distros/platforms?
Assume your development environment is x86 64/amd64-based.
Please try to test it in various Distros of Bigtop docker images for x86
64/amd64 first.
(https://hub.docker.com/r/bigtop/slaves/tags)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
