iwasakims commented on code in PR #1098:
URL: https://github.com/apache/bigtop/pull/1098#discussion_r1162223270


##########
bigtop-packages/src/common/solr/install_solr.sh:
##########
@@ -136,6 +136,7 @@ cp -a ${BUILD_DIR}/bin/oom_solr.sh $PREFIX/$LIB_DIR/bin
 #cp -a ${BUILD_DIR}/server/scripts/cloud-scripts/*.sh $PREFIX/$LIB_DIR/bin
 #cp -a $DISTRO_DIR/zkcli.sh $PREFIX/$LIB_DIR/bin
 chmod 755 $PREFIX/$LIB_DIR/bin/*
+chmod 755 $PREFIX/$LIB_DIR/server/scripts/cloud-scripts/*

Review Comment:
   I prefer applying chmod to specific file rather than using wildcard.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to