iwasakims commented on code in PR #1109:
URL: https://github.com/apache/bigtop/pull/1109#discussion_r1191098311
##########
bigtop-packages/src/common/gpdb/do-component-configure:
##########
@@ -16,4 +16,13 @@
set -ex
-./configure --prefix=$1 --disable-orca CFLAGS=-fcommon
+if [ -f /etc/os-release ]; then
+ . /etc/os-release
+fi
+
+OS="$ID"
+if [ "${OS}" = "fedora" ]; then
+ ./configure --prefix=$1 --with-python --with-libxml --with-gssapi
--disable-orca --disable-rpath CFLAGS='-fcommon -Wno-implicit-fallthrough'
Review Comment:
@guyuqi This looks not the right solution. We should not expect users to set
LD_LIBRARY_PATH. If we really need to disable rpath, the RPM should add a
configuration file under /etc/ld.so.conf.d/ and run ldconfig on installing.
How about setting `QA_RPATHS=$(( 0x0001|0x0002 ))` on rpmbuild as the
message suggest?
```
+ /usr/lib/rpm/check-rpaths
*******************************************************************************
*
* WARNING: 'check-rpaths' detected a broken RPATH OR RUNPATH and will cause
* 'rpmbuild' to fail. To ignore these errors, you can set the
* '$QA_RPATHS' environment variable which is a bitmask allowing the
* values below. The current value of QA_RPATHS is 0x0002.
*
* 0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor
* issue but are introducing redundant searchpaths without
* providing a benefit. They can also cause errors in multilib
* environments.
* 0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute
* nor relative filenames and can therefore be a SECURITY risk
* 0x0004 ... insecure RPATHs; these are relative RPATHs which are a
* SECURITY risk
* 0x0008 ... the special '$ORIGIN' RPATHs are appearing after other
* RPATHs; this is just a minor issue but usually unwanted
* 0x0010 ... the RPATH is empty; there is no reason for such RPATHs
* and they cause unneeded work while loading libraries
* 0x0020 ... an RPATH references '..' of an absolute path; this will break
* the functionality when the path before '..' is a symlink
*
*
* Examples:
* - to ignore standard and empty RPATHs, execute 'rpmbuild' like
* $ QA_RPATHS=$(( 0x0001|0x0010 )) rpmbuild my-package.src.rpm
* - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths
like
* $ RPM_BUILD_ROOT=<top-dir> /usr/lib/rpm/check-rpaths
*
*******************************************************************************
ERROR 0001: file '/usr/lib/gpdb/lib/postgresql/plpython2.so' contains a
standard '/usr/lib64' in [/usr/lib64:/ext/python/lib]
WARNING 0002: file '/usr/lib/gpdb/lib/postgresql/plpython2.so' contains an
invalid '/ext/python/lib' in [/usr/lib64:/ext/python/lib]
error: Bad exit status from /var/tmp/rpm-tmp.4dIXaK (%install)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
