guyuqi commented on code in PR #1109:
URL: https://github.com/apache/bigtop/pull/1109#discussion_r1192925154
##########
bigtop-packages/src/common/gpdb/do-component-configure:
##########
@@ -16,4 +16,13 @@
set -ex
-./configure --prefix=$1 --disable-orca CFLAGS=-fcommon
+if [ -f /etc/os-release ]; then
+ . /etc/os-release
+fi
+
+OS="$ID"
+if [ "${OS}" = "fedora" ]; then
+ ./configure --prefix=$1 --with-python --with-libxml --with-gssapi
--disable-orca --disable-rpath CFLAGS='-fcommon -Wno-implicit-fallthrough'
Review Comment:
Thanks for the comments and Sorry for the late reply.
Agreed with your suggestion.
We should not disable rpath check in Gpdb binary building in order to
prevent users from setting unnecessary `LD_LIBRARY_PATH `when installing gpdb
rpm.
`QA_RPATHS=$(( 0x0001|0x0002 ))` is to skip the errors of rpath check.
But it appears that it is not working when I add the settings in
`~/.rpmmacros` or `export ` it as the global variable.
From https://fedoraproject.org/wiki/Changes/Broken_RPATH_will_fail_rpmbuild:
what about setting Broken RPATH to null by `%global __brp_check_rpaths
%{nil}` which also performs as skipping the errors of rpath check.
I also remove unnecessary `LD_LIBRARY_PATH` setting in puppet scripts as
shown in 5th commit. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
