sekikn commented on PR #1184: URL: https://github.com/apache/bigtop/pull/1184#issuecomment-1765502029
Thank you for the contribution, @JiaLiangC. In my understanding, dh_strip_nondeterminism is for reproducible build as you pointed out and it's a good thing in general, so I wouldn't like to override it unnecessarily if dh_strip_nondeterminism is not so time-consuming. I roughly measured the time dh_strip_nondeterminism is running, and for most of the components you modified, dh_strip_nondeterminism finished in a few minutes at most and didn't take a major part of the whole build time. Only Flink and YCSB took a long time for running dh_strip_nondeterminism (1h+ and 30m respectively) and your PR is significantly effective (it shortened the whole build time to 25m and 4m). Based on the observation above, how about overriding dh_strip_nondeterminism only in Flink and YCSB? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
