sekikn commented on PR #1204:
URL: https://github.com/apache/bigtop/pull/1204#issuecomment-1788483889
Thank you for the update and advice @JiaLiangC @guyuqi.
As Yuqi said, you can use the images published on DockerHub for running
build (use bigtop/slaves for this purpose, in which both puppet and toolchain
are installed) and smoke test (use bigtop/puppet, in which only puppet is
installed).
But I've just found that the current trunk images are obsolete. They were
built over a year ago and the "trunk-rockylinux-8" image is recognized as
"RedHat" by facter.
```
$ docker run --rm -it bigtop/puppet:trunk-rockylinux-8 cat
/etc/redhat-release
Unable to find image 'bigtop/puppet:trunk-rockylinux-8' locally
trunk-rockylinux-8: Pulling from bigtop/puppet
...
Rocky Linux release 8.5 (Green Obsidian)
$ docker run --rm -it bigtop/puppet:trunk-rockylinux-8 facter operatingsystem
RedHat
$ docker images bigtop/puppet:trunk-rockylinux-8
REPOSITORY TAG IMAGE ID CREATED SIZE
bigtop/puppet trunk-rockylinux-8 26e196c3c91c 13 months ago 570MB
```
But if we rebuild it based on the latest Rocky image, facter recognizes it
as "Rocky".
```
$ cd docker/bigtop-puppet
$ ./build.sh trunk-rockylinux-8
...
$ docker images bigtop/puppet:trunk-rockylinux-8
REPOSITORY TAG IMAGE ID CREATED SIZE
bigtop/puppet trunk-rockylinux-8 428a4b9f5c8c 12 minutes ago 606MB
$ docker run --rm -it bigtop/puppet:trunk-rockylinux-8 cat
/etc/redhat-release
Rocky Linux release 8.8 (Green Obsidian)
$ docker run --rm -it bigtop/puppet:trunk-rockylinux-8 facter operatingsystem
Rocky
```
So the following code
```
if ( $operatingsystem =~ /^(?i:(redhat))$/ and 0 <=
versioncmp($operatingsystemmajrelease, '8')) {
```
should be as follows. Would you fix it?
```
if ($operatingsystem =~ /^(?i:(redhat|rocky))$/ and 0 <=
versioncmp($operatingsystemmajrelease, '8')) {
```
Regarding the trunk images, they should be periodically built and pushed
into DockerHub so that developers can use the latest version. I'll configure
the CI for doing so later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
