timyuer commented on code in PR #1236:
URL: https://github.com/apache/bigtop/pull/1236#discussion_r1501997718
##########
bigtop-packages/src/common/bigtop-select/distro-select:
##########
@@ -154,7 +154,7 @@ def listPackages( packages ):
if packages == None:
packages = leaves
- packages.sort()
+ sorted(packages)
Review Comment:
> The `sorted` function doesn't change the original list, so these lines
seem to have no effect.
Thank you for your feedback. It has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
