iwasakims commented on code in PR #1243:
URL: https://github.com/apache/bigtop/pull/1243#discussion_r1514258713


##########
bigtop_toolchain/bin/puppetize.sh:
##########
@@ -69,7 +69,8 @@ case ${ID}-${VERSION_ID} in
         puppet module install puppetlabs-stdlib --version 4.12.0
         # Enabling the PowerTools and EPEL repositories via Puppet doesn't 
seem to work in some cases.
         # As a workaround for that, enable the former here in advance of 
running the Puppet manifests.
-        dnf config-manager --set-enabled crb
+        dnf config-manager --set-enabled crb devel
+        dnf install -y redhat-lsb initscripts

Review Comment:
   > hadoop installed need /lib/lsb/init-functions in 
bigto/puppet:trunk-rockylinux-9 ,But it didn't.
   
   If we need Hadoop too for running smoke-tests of Alluxio, the dependency 
between classes of alluxio and hadoop in the puppet manifest.
   
   > I think this is the base environment and should be installed in puppet. 
   
   The docker image is mainly for the ease of development. RPM packages should 
work without assuming the environment. It appropriate package dependency is 
defined in alluxio package, init-functions is automatically installed by 
yum/dnf.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to