iwasakims commented on code in PR #1251:
URL: https://github.com/apache/bigtop/pull/1251#discussion_r1560430135
##########
docker/bigtop-puppet/build.sh:
##########
@@ -29,7 +29,14 @@ fi
PREFIX=$(echo "$1" | cut -d '-' -f 1)
OS=$(echo "$1" | cut -d '-' -f 2)
+
+# BIGTOP-4082 get the openEuler OS version
+if [ "${OS}" == "openeuler" ];then
+VERSION=$(echo "$1" | cut -d '-' -f 3-5)
+else
VERSION=$(echo "$1" | cut -d '-' -f 3)
+fi
+
Review Comment:
The scope is not limited to openEuler. Please remove the conditional.
@MacChen01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]