iwasakims commented on code in PR #1268:
URL: https://github.com/apache/bigtop/pull/1268#discussion_r1599375633
##########
packages.gradle:
##########
@@ -102,7 +102,7 @@ def isValidMavenBuildThreads(threads) {
}
def getPkgNameSuffix(component, type) {
- def originalSuffix = type.equalsIgnoreCase("deb") ?
component.deb_pkg_suffix : component.rpm_pkg_suffix
+ def originalSuffix = type.equalsIgnoreCase("deb") ?
component.deb_pkg_suffix?:"" : component.rpm_pkg_suffix?:"%{nil}"
Review Comment:
@Kapkiai I feel chaining ternary operator and elvis operator spoils
readability. How about splitting the line and adding whitespace around the `?:`
operator? like:
```
type.equalsIgnoreCase("deb") ?
component.deb_pkg_suffix ?: "" :
component.rpm_pkg_suffix ?: "%{nil}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
