JiaLiangC commented on code in PR #1263:
URL: https://github.com/apache/bigtop/pull/1263#discussion_r1607519625
##########
bigtop-deploy/puppet/manifests/python.pp:
##########
@@ -14,16 +14,70 @@
# limitations under the License.
class python {
- if (($operatingsystem == 'Ubuntu' and 0 <=
versioncmp($operatingsystemmajrelease, '22.04'))) {
- file { '/usr/bin/python':
- ensure => 'link',
- target => '/usr/bin/python2',
+
+ define set_python_alternatives($command) {
+ exec { $name:
+ command => $command,
+ unless => "/usr/sbin/update-alternatives --display python | grep
'/usr/bin/python3'",
+ path => ['/bin', '/usr/bin', '/sbin', '/usr/sbin'],
}
}
-
- if ($operatingsystem == 'openEuler') {
- package { 'python3-unversioned-command':
- ensure => 'present'
+
+ define change_python_interpreter($file, $interpreter) {
+ file_line { "change_interpreter_in_${name}":
+ path => $file,
+ line => "#!${interpreter}",
+ match => '^#!.*python.*$',
+ }
+ }
+
+ case $operatingsystem {
+ /(?i:(centos|fedora|redhat|rocky))/: {
+ if ($operatingsystem != 'Fedora') {
+ case $operatingsystemmajrelease {
+ '9': {
+ package { 'python-unversioned-command':
+ ensure => 'present',
+ }
+ }
+ '8': {
+ set_python_alternatives { 'set-python3':
+ command => '/usr/sbin/update-alternatives --set
python /usr/bin/python3',
+ }
+ }
+ '7': {
+ change_python_interpreter { 'yum':
+ file => '/usr/bin/yum',
+ interpreter => '/usr/bin/python2.7',
+ }
+ change_python_interpreter { 'urlgrabber-ext-down':
+ file => '/usr/libexec/urlgrabber-ext-down',
+ interpreter => '/usr/bin/python2.7',
+ }
+
+ set_python_alternatives { 'install-python3':
+ command => '/usr/sbin/update-alternatives --install
/usr/bin/python python /usr/bin/python3 1',
+ }
Review Comment:
Okay, I did overlook the fact that the deploy image doesn't have Python 3
installed by default. I'll add that part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
