iwasakims commented on code in PR #1281:
URL: https://github.com/apache/bigtop/pull/1281#discussion_r1642613544
##########
provisioner/docker/docker-hadoop.sh:
##########
@@ -271,7 +271,11 @@ env-check() {
echo "Check docker:"
docker -v || exit 1
echo "Check docker-compose:"
- $DOCKER_COMPOSE_CMD -v || exit 1
+ if [ "$DOCKER_COMPOSE_CMD" == "docker-compose" ]; then
+ $DOCKER_COMPOSE_CMD -v || exit 1
+ elif [ "$DOCKER_COMPOSE_CMD" == "docker compose" ]; then
+ $DOCKER_COMPOSE_CMD version || exit 1
+ fi
Review Comment:
@yamasakisua basically LGTM.
- Could you replace tabs with whitespaces?
- Could you remove a trailing whitespace in line 278?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
