kevinw66 commented on code in PR #148: URL: https://github.com/apache/bigtop-manager/pull/148#discussion_r1918572071
########## bigtop-manager-server/src/main/resources/stacks/extra/1.0.0/services/seatunnel/metainfo.xml: ########## @@ -0,0 +1,69 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ https://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. +--> + +<metainfo> + <service> + <name>seatunnel</name> + <display-name>SeaTunnel</display-name> + <desc> + SeaTunnel is a next-generation, high-performance, distributed data integration tool, capable of synchronizing vast amounts of data daily. It's trusted by numerous companies for its efficiency and stability. + </desc> + <version>2.3.8</version> + <user>seatunnel</user> + + <components> + <component> + <name>seatunnel_master</name> + <display-name>SeaTunnel Master</display-name> + <category>master</category> Review Comment: The category current only has server/client ########## bigtop-manager-stack/bigtop-manager-stack-extra/src/main/java/org/apache/bigtop/manager/stack/extra/param/ExtraParams.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bigtop.manager.stack.extra.param; + +import org.apache.bigtop.manager.common.message.entity.payload.CommandPayload; +import org.apache.bigtop.manager.common.utils.Environments; +import org.apache.bigtop.manager.stack.core.spi.param.BaseParams; + +import org.apache.commons.lang3.SystemUtils; + +import lombok.NoArgsConstructor; +import lombok.extern.slf4j.Slf4j; + +import java.io.File; + +@Slf4j +@NoArgsConstructor +public abstract class ExtraParams extends BaseParams { Review Comment: group() and stackHome() don't need to override, ExtraParams is the same as BigtopParams ########## bigtop-manager-server/src/main/resources/stacks/extra/1.0.0/services/seatunnel/metainfo.xml: ########## @@ -0,0 +1,69 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ https://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. +--> + +<metainfo> + <service> + <name>seatunnel</name> + <display-name>SeaTunnel</display-name> + <desc> + SeaTunnel is a next-generation, high-performance, distributed data integration tool, capable of synchronizing vast amounts of data daily. It's trusted by numerous companies for its efficiency and stability. + </desc> + <version>2.3.8</version> + <user>seatunnel</user> + + <components> + <component> + <name>seatunnel_master</name> + <display-name>SeaTunnel Master</display-name> + <category>master</category> + <cardinality>1+</cardinality> + </component> + + <component> + <name>seatunnel_worker</name> + <display-name>SeaTunnel Worker</display-name> + <category>worker</category> Review Comment: same here ########## bigtop-manager-server/src/main/resources/stacks/extra/1.0.0/services/seatunnel/configuration/seatunnel-env.sh.xml: ########## @@ -0,0 +1,59 @@ +<?xml version="1.0"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ https://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. +--> + +<configuration> + <property> + <name>content</name> + <description>This is the freemarker template for seatunnel-env.sh file</description> + <value><![CDATA[ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# The java implementation to use. +export JAVA_HOME=${java_home} + +export SEATUNNEL_HOME=${seatunnel_home} + +# Home directory of spark distribution. +SPARK_HOME=${spark_home} +# Home directory of flink distribution. +FLINK_HOME=${flink_home} Review Comment: Does SeaTunnel requires both Spark and Flink to be installed? Even if we are using Zeta engine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
