eubnara opened a new pull request, #1388:
URL: https://github.com/apache/bigtop/pull/1388
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
Restore `conf-select` that was unintentionally removed in BIGTOP-4063
(#1236, "Adapt bigtop-select to Python 3"). The PR was meant to port the
script to Python 3 but deleted it instead.
The script is still referenced by Ambari's BIGTOP stack:
- `stacks/BIGTOP/*/properties/stack_tools.json` points `conf_selector` at
`/usr/lib/bigtop-select/conf-select`.
- `ambari-common`'s `resource_management.libraries.functions.conf_select`
invokes that path during stack-upgrade and config patching, and 30+
service scripts (HDFS, YARN, HBASE, HIVE, KAFKA, SPARK, FLINK, LIVY,
TEZ, ZEPPELIN, ZOOKEEPER, ALLUXIO, RANGER_KMS, ...) depend on it.
Changes:
- Restore `conf-select` with `#!/usr/bin/env python3` (content otherwise
identical to the pre-BIGTOP-4063 version; already Python 3 compatible).
- Re-add `CONF_SELECTOR=conf-select` and its `install` line in
`install_select.sh`.
- Re-add `Source3: conf-select` and its `%prep` install line in
`bigtop-select.spec`.
### How was this patch tested?
- `python3 -m py_compile
bigtop-packages/src/common/bigtop-select/conf-select`
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'BIGTOP-3638. Your PR title ...')?
- [x] Make sure that newly added files do not have any licensing issues.
When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
