magnuma3 opened a new pull request, #1404:
URL: https://github.com/apache/bigtop/pull/1404
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
bigtop_toolchain is intended to install the latest matching ant (1.9.x) and
maven (3.9.x) versions:
```
# maven.pp
$mvnversion = latest_maven_binary("3.9.[0-9]*")
# ant.pp
$ant = latest_ant_binary("1.9.[0-9]*")
```
But both resolver functions fetch the archive.apache.org directory listing
with an HTML-escaped ampersand in the URL:
```
%x(curl -L --stderr /dev/null
'https://archive.apache.org/dist/maven/maven-3/?F=0&V=1' | ...)
```
Because of "&", the V=1 (version sort) parameter is not applied. The
listing is sorted lexicographically, so "tail -1" picks the wrong entry. For
maven this resolves 3.9.9 instead of the latest 3.9.16:
```
$ curl -L --stderr /dev/null
'https://archive.apache.org/dist/maven/maven-3/?F=0&V=1' | grep -o
'<li>.*href="3.9.[0-9]*/"' | tail -1 | grep -o '3.9.[0-9]*'
3.9.9
$ curl -L --stderr /dev/null
'https://archive.apache.org/dist/maven/maven-3/?F=0&V=1' | grep -o
'<li>.*href="3.9.[0-9]*/"' | tail -1 | grep -o '3.9.[0-9]*'
3.9.16
```
latest_ant_binary has the same bug and fails to pick up the latest 1.9.x.
Fix: replace "&" with "&" in the listing URLs in latest_maven_binary.rb
and latest_ant_binary.rb.
### How was this patch tested?
Built the bigtop/puppet Docker image for an Navix 9 (EL9-based) distribution
with this patch. latest_maven_binary now resolves 3.9.16 (previously 3.9.9) and
latest_ant_binary resolves the latest 1.9.x, and both were downloaded and
installed successfully during the image build.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues.
When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
