On Tue, Feb 11, 2014 at 12:22 PM, Olemis Lang <[email protected]> wrote:
> On Tue, Feb 11, 2014 at 2:38 PM, Olemis Lang <[email protected]> wrote: > > > > > On Tue, Feb 11, 2014 at 1:14 PM, Ryan Ollos <[email protected] > >wrote: > > > >> In `trac.resource:ResourceSystem`, there is a method > >> `get_known_neighborhoods`. It doesn't appear to be used anywhere so it > is > >> probably not causing any trouble, but there is an unresolved reference > >> "manager": > >> > >> def get_known_neighborhoods(self): > >> """Return a list of all the realm names of neighborhoods.""" > >> realms = [] > >> for connector in self.resource_connectors: > >> for realm in manager.get_supported_neighborhoods() or []: > >> realms.append(realm) > >> return realms > >> > >> It seems like we should either fix it or remove the code, in case > someone > >> tries to utilize the method. > >> > >> Olemis, can you direct us to a proper fix? > >> > >> > > Oh yes ! In a minute , I did not notice that . I'll propose a patch with > > test cases > > ;) > > > > > > > please review the patch attached to #754 > > Thanks for the quick fix! I'll commit the change today.
