On Wed, Apr 2, 2014 at 2:55 PM, Olemis Lang <[email protected]> wrote:
> On Wed, Apr 2, 2014 at 5:49 PM, Ryan J Ollos <[email protected]> wrote: > > > On Tue, Apr 1, 2014 at 11:24 PM, Apache Bloodhound < > > [email protected]> wrote: > > > > [...] > > > > > > > Proposed change is to use a fully-qualified name for `[trac] > > > environment_factory` and `[trac] request_factory`. Patch in > > > [attachment:t795.diff]. > > > > > > `load_class` is from SO:547867/121694, with exception handling added. > > > > > > -- > > > Ticket URL: <https://issues.apache.org/bloodhound/ticket/795#comment:1 > > > > > Apache Bloodhound <https://issues.apache.org/bloodhound/> > > > The Apache Bloodhound issue tracker > > > > > > > > > I will wait until Friday for feedback before committing this change. > > > In this case I do not think I can be of much help because I really do not > run BH with these hooks . I do not even activate default bootstrap handler > which is responsible for invoking the hooks under the hood . Anyone that is a developer on this project with a development environment should be able to evaluate this change and give feedback, regardless of whether it directly affects whatever site you run. Presumably you would need to change your `[trac] request_factory` and `[trac] environment_factory` from a path to a fully-qualified class name since the change affects how the hooks are loaded. Didn't you develop the "hooks" code?
