Excellent. Thanks for that!

On 6 January 2015 at 10:18, Thimal Kempitiya <[email protected]> wrote:

> Thanks Gray I commit the changes to the trunk
>
> On Tue, Jan 6, 2015 at 3:08 PM, Gary Martin <[email protected]>
> wrote:
>
> > On 24 December 2014 at 03:40, Ryan Ollos <[email protected]> wrote:
> >
> > > On Tue, Dec 23, 2014 at 11:55 AM, Gary Martin <
> [email protected]>
> > > wrote:
> > >
> > > > Hi Thimal,
> > > >
> > > > Sorry I left it so long. I was hoping someone else might want to say
> > > > something about your patch. Personally I am happy enough with it for
> it
> > > to
> > > > be committed. It might be worth cleaning up the wording and if I were
> > > being
> > > > more picky I would also point out that there are some deviations from
> > > PEP8
> > > > in the patch. Obviously the script as a whole suffers from some PEP8
> > > > problems which I wouldn't expect you to solve with your proposed
> > changes.
> > > >
> > > > If there are no objections I'd suggest that Thimal commits the
> changes
> > to
> > > > trunk himself and we can fix the wording later.
> > > >
> > >
> > > Sounds good to me.
> > >
> >
> >
> > ​Thimal,
> >
> > As nobody has raised any objections, you should commit the change to
> trunk.
> > Sorry for the delay.
> >
> > Cheers,
> >     Gary​
> >
>
>
>
> --
>
>
>
>
> *Thimal Kempitiya <http://www.facebook.com/thimalk>
> UndergraduateDepartment
> of Computer Science and Engineering University of Moratuwa.*
>

Reply via email to