On Thu, May 6, 2021 at 5:26 PM Gary Martin <[email protected]> wrote: >...
> With github in the mix we will naturally open ourselves up to the > possibility of accepting changes from non-committers as pull requests. > Beyond concerns around ownership of the code and how large a change would > require an ICLA, I think this is something that is desirable. > The person who pushes/merges the PR becomes responsible for the change under their ICLA. There is definitely a lot of <hand-wave> on what "large" means. Honestly: I think that isn't something for the BH community to worry about right now. If we get a PR, then we should do a Happy Dance, rather than pondering on requesting an ICLA. This leaves the question of whether there is any advantage to Bloodhound > committers also using forks on github from which to prepare their code and > organise their own pull requests. To be honest I don't think I am going to > mind feature branches being created a bit more directly but perhaps others > have stronger views. > I think we should just go with Commit-Then-Review for all committers. Just make the change. All committers are all trusted to move the project forward in a productive fashion. We can always make further edits to fix things. Branches and PRs interposed between committers and the repository suggest a lack of trust. Let's trust, then fix things as problems arise. Note that we aren't going to be making releases any time soon, so any problems will not extend beyond this community. And frankly: we need to lower the barrier as much as possible. This community needs some forward motion, and should avoid anything that might slow that down. Cheers, -g
