----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28326/#review63881 -----------------------------------------------------------
Ship it! Ship It! - Sijie Guo On Nov. 21, 2014, 11:40 a.m., Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28326/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 11:40 a.m.) > > > Review request for bookkeeper. > > > Bugs: BOOKKEEPER-799 > https://issues.apache.org/jira/browse/BOOKKEEPER-799 > > > Repository: bookkeeper-git > > > Description > ------- > > Fix is to check each write quorum after each response. If there is no write > quorum with |ackQuorum| nodes available, then it is not possible for a writer > to form a quorum without at least one of the nodes we have heard a response > from. > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RoundRobinDistributionSchedule.java > b34ff75 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/RoundRobinDistributionScheduleTest.java > ce9aab9 > > Diff: https://reviews.apache.org/r/28326/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Kelly > >
