[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236613#comment-14236613
]
Rakesh R commented on BOOKKEEPER-634:
-------------------------------------
Thanks Sijie.
bq.following code is problematic. you will have definitely race condition on
completedLedgerCount because checking and updating are in different threads.
what 'limit' means you need to stop updating (even issuing update operations)
if you already issued 'limit' update operations.
Exactly 'limit' semantic needs to be changed. I tried to stop updating the
ledgers on successful completion. yes, this is problamatic since I dont have
full control over ratelimiter. The reason why I'm increment
'completedLedgerCount' only on successful ledger updation is, to give chance
to all ledgers. Otw there could be many untouched ledgers, consider there are
10K ledgers and I passed limit as 100. It may hit always already updated
ledgers and exit the command. I'm planning to change the name to
'approximatelimit', considering close to the limit. Whats your opinion?
> Provide admin tool to rename bookie identifier in ledger metadata
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-634
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.1
>
> Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
> 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> 003-BOOKKEEPER-634-update-bookieid-in-ledger.patch,
> BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
> BOOKKEEPER-634.patch
>
>
> This JIRA to discuss about admin tool for changing the bookie's IP to
> hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
