> On Jan. 7, 2015, 1:11 p.m., Ivan Kelly wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/UpdateLedgerOp.java,
> > line 137
> > <https://reviews.apache.org/r/28835/diff/4/?file=805357#file805357line137>
> >
> > These exceptions should be thrown up to the caller.
Throws new IOException("Exception while updating ledger", e);. Also, handled
#run() method exceptions and throws RuntimeException. any more comments?
- Rakesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28835/#review67018
-----------------------------------------------------------
On Jan. 11, 2015, 3:41 p.m., Rakesh R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28835/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2015, 3:41 p.m.)
>
>
> Review request for bookkeeper, fpj, Ivan Kelly, and Sijie Guo.
>
>
> Bugs: BOKKEEPER-634
> https://issues.apache.org/jira/browse/BOKKEEPER-634
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> admin tool for changing the bookie's identifier to IP/hostname
>
>
> Diffs
> -----
>
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
> a1e4639
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/UpdateLedgerOp.java
> PRE-CREATION
>
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/UpdateLedgerCmdTest.java
> PRE-CREATION
>
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/UpdateLedgerOpTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28835/diff/
>
>
> Testing
> -------
>
> Added few tests
>
>
> Thanks,
>
> Rakesh R
>
>
