Rakesh R created BOOKKEEPER-837:
-----------------------------------

             Summary: UpdateLedgerOp - Replace AbstractFuture with 
SettableFuture
                 Key: BOOKKEEPER-837
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-837
             Project: Bookkeeper
          Issue Type: Sub-task
            Reporter: Rakesh R
            Assignee: Rakesh R


+Review comment :+ Using AbstractFuture is too tight with guava's internal 
implementation. Instead it would be good to use a variable for the settable 
future.

{code}
 class Read... implements GenericCallback {

 SettableFuture future = ...;
  public void operationComplete(..) {
    future.set(null); 
    // future.setException(..)
  }
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to