Hi Sijie,

Thanks for getting this out. I have a couple of comments.

The release date needs to be set in CHANGES.txt (set it to the date
you cut the release).
The copyright year needs to be updated in all the NOTICE files (the
toplevel, and the onces used for the binaries).

Otherwise the release looks good :)

-Ivan

On Sat, Feb 14, 2015 at 5:02 PM, Flavio Junqueira
<[email protected]> wrote:
> I'm getting a lot of test errors, am I the only one to observe this?
>
> Results :
>
> Failed tests:   
> testCloseDuringOp[0](org.apache.bookkeeper.client.BookKeeperTest): Close 
> never completed
>   testShutdown(org.apache.bookkeeper.replication.AuditorBookieTest): Auditor 
> re-election is not happened for auditor failure! expected not same
>   
> testIndexCorruption(org.apache.bookkeeper.replication.AuditorPeriodicCheckTest):
>  Ledger should be under replicated expected:<4> but was:<-1>
>   
> testPeriodicCheckWhenDisabled(org.apache.bookkeeper.replication.AuditorPeriodicCheckTest):
>  All should be underreplicated
>   testShutdown(org.apache.bookkeeper.replication.AutoRecoveryMainTest): 
> AuditorElector should not be running
>
> Tests in error:
>   
> testBookieRestartContinuously(org.apache.bookkeeper.bookie.BookieShutdownTest):
>  test timed out after 150000 milliseconds
>   testCloseDuringOp[1](org.apache.bookkeeper.client.BookKeeperTest): test 
> timed out after 60000 milliseconds
>   
> testShouldNotGetTheFragmentIfThereIsNoMissedEntry(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testShouldGetTwoFrgamentsIfTwoBookiesFailedInSameEnsemble(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testShouldNotGetAnyFragmentIfNoLedgerPresent(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testShouldGetFailedEnsembleNumberOfFgmntsIfEnsembleBookiesFailedOnNextWrite(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testShouldGetOneFragmentWithSingleEntryOpenedLedger(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testSingleEntryAfterEnsembleChange(org.apache.bookkeeper.client.TestLedgerChecker):
>  test timed out after 3000 milliseconds
>   
> testClosedSingleEntryLedger(org.apache.bookkeeper.client.TestLedgerChecker): 
> test timed out after 3000 milliseconds
>   
> testPeriodicCheckWhenLedgerDeleted(org.apache.bookkeeper.replication.AuditorPeriodicCheckTest):
>  test timed out after 60000 milliseconds
>   
> testRWShouldCleanTheLedgerFromUnderReplicationIfLedgerAlreadyDeleted[0](org.apache.bookkeeper.replication.TestReplicationWorker):
>  test timed out after 3000 milliseconds
>   
> testRWShouldCleanTheLedgerFromUnderReplicationIfLedgerAlreadyDeleted[1](org.apache.bookkeeper.replication.TestReplicationWorker):
>  test timed out after 3000 milliseconds
>   
> testRWShouldCleanTheLedgerFromUnderReplicationIfLedgerAlreadyDeleted[2](org.apache.bookkeeper.replication.TestReplicationWorker):
>  test timed out after 3000 milliseconds
>   testCompat400(org.apache.bookkeeper.test.TestBackwardCompat): test timed 
> out after 60000 milliseconds
>   testCompat410(org.apache.bookkeeper.test.TestBackwardCompat): test timed 
> out after 60000 milliseconds
>
>> On 13 Feb 2015, at 09:23, Sijie Guo <[email protected]> wrote:
>>
>> This is the first release candidate for Apache BookKeeper, version 4.3.1.
>> It fixes the following issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12328755&styleName=Html&projectId=12311293
>>
>> *** Please download, test and vote by Feb 17th 2015, 10:00 GMT.
>>
>> Note that we are voting upon the source (tag), binaries are provided for
>> convenience.
>>
>> Source and binary files:
>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.3.1-candidate-0/
>>
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1005/
>>
>> The tag to be voted upon:
>> release-4.3.1 (b830f4e88c991d67a84ed883c6136989a54c2556)
>>
>> BookKeeper's KEYS file containing PGP keys we use to sign the release:
>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>
>> Please download the the source package, and follow the README to build
>> and run a bookkeeper and hedwig service.
>

Reply via email to