[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386077#comment-14386077
 ] 

Rakesh R commented on BOOKKEEPER-847:
-------------------------------------

[~hustlmsp] since this is a straight fix and not harming any other flows, I 
agree with your point. Please go ahead to fix this case.

Thanks [~zhaijia] for catching this.

Just one comment. Should we complete the call back by calling 
{{ensembleUpdatedCb#processResult(Code.UnexpectedConditionException, null, 
null);}} if the condition falls in else block ?
{code}
+        else {
+            LOG.warn("Bookie {} doesn't exist in ensemble {} anymore.", 
oldBookie, ensemble);
+        }
{code}


> ArrayIndexOutOfBoundsException in LedgerFragmentReplicator::updateEnsembleInfo
> ------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-847
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-847
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>         Attachments: BOOKKEEPER-847.patch
>
>
> ArrayIndexOutOfBoundsException in 
> LedgerFragmentReplicator::updateEnsembleInfo, because update ensemble info 
> might happen after re-read ledger metadata, so the ensemble might already 
> change. if ensemble is already changed, skip replacing the bookie doesn't 
> exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to