[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486790#comment-14486790
 ] 

Sijie Guo commented on BOOKKEEPER-841:
--------------------------------------

thanks [~merlimat] 

The patch looks good. I am also working on similar stuff. but I am doing a bit 
different here. I tried wrapping the serialized ledger map as like a ledger 
entry whose ledger id is -1. so it would be more compatible with old version 
and 'rollback' friendly. since ledger id '-1' will be skipped by old version 
bookies, so we could rollback without worrying about data.

> Bookie should calculate ledgers map writing a new entry log file
> ----------------------------------------------------------------
>
>                 Key: BOOKKEEPER-841
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-841
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Matteo Merli
>             Fix For: 4.4.0
>
>         Attachments: 
> 0001-BOOKKEEPER-841-Bookie-should-calculate-ledgers-map-w.patch
>
>
> Bookie should calculate ledgers map when writing a new entry log file. so the 
> bookie doesn't need to scan that entry log file again, which it would improve 
> garbage collection efficiency 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to