----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33098/#review79994 -----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java <https://reviews.apache.org/r/33098/#comment129724> this should be expireAfterAccess, right? maybe make the expiration configurable? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java <https://reviews.apache.org/r/33098/#comment129725> it would be better to check if e.getCause instanceof IOException. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java <https://reviews.apache.org/r/33098/#comment129726> expireAfterAccess? configurable time? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java <https://reviews.apache.org/r/33098/#comment129727> expireAfterAccess? configurable time? - Sijie Guo On April 11, 2015, 12:06 a.m., Matteo Merli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33098/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 12:06 a.m.) > > > Review request for bookkeeper. > > > Bugs: BOOKKEEPER-852 > https://issues.apache.org/jira/browse/BOOKKEEPER-852 > > > Repository: bookkeeper-git > > > Description > ------- > > Maps with ledger descriptors and master-keys are not cleaned after a ledger > gets deleted. > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 8b40853 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java > 45be763 > > Diff: https://reviews.apache.org/r/33098/diff/ > > > Testing > ------- > > > Thanks, > > Matteo Merli > >
