> On April 14, 2015, 7:21 a.m., Sijie Guo wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java, > > line 824 > > <https://reviews.apache.org/r/33094/diff/1/?file=923861#file923861line824> > > > > why change to #get(0)? isn't getFirst clear than #get(0)?
I think this was because this patch was based on some other patch that was using an ArrayList instead of the LinkedList for toFlush. ArrayList and List have no getFirst(), only get(int). I'll change it back to getFirst() for now. - Matteo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33094/#review79996 ----------------------------------------------------------- On April 10, 2015, 9:45 p.m., Matteo Merli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33094/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 9:45 p.m.) > > > Review request for bookkeeper. > > > Bugs: BOOKKEEPER-850 > https://issues.apache.org/jira/browse/BOOKKEEPER-850 > > > Repository: bookkeeper-git > > > Description > ------- > > When using group commit to reduce the number of fsync operations in the > bookie journal, the timeout is rounded to the next millisecond. > If the group commit is set to 1ms, that would mean that the effective wait > time will be closer to 2ms. > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java > 7384330 > > Diff: https://reviews.apache.org/r/33094/diff/ > > > Testing > ------- > > > Thanks, > > Matteo Merli > >
